[libcxx-commits] [PATCH] D75554: Partially inline basic_string::assign(__s [, __n]) methods.

[Martijn Vels via Phabricator via libcxx-commits]

mvels added inline comments.


================
Comment at: libcxx/include/string:2288
+  } else {
+    __assign_maybe_alias(__s);
+  }
----------------
ldionne wrote:
> I don't quite understand why we don't also call `__assign_maybe_alias(__s, __n);` in this case?
That is a bug (the checks actually fail on it) resulting from some lazy copy-paste from my side :\ Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75554/new/

https://reviews.llvm.org/D75554