[libcxx-commits] [PATCH] D75554: Partially inline basic_string::assign(__s [, __n]) methods.
    Louis Dionne via Phabricator via libcxx-commits 
    libcxx-commits at lists.llvm.org
       
    Tue Mar  3 13:47:09 PST 2020
    
    
  
ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
================
Comment at: libcxx/include/string:2288
+  } else {
+    __assign_maybe_alias(__s);
+  }
----------------
I don't quite understand why we don't also call `__assign_maybe_alias(__s, __n);` in this case?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75554/new/
https://reviews.llvm.org/D75554
    
    
More information about the libcxx-commits
mailing list