[libcxx-commits] [PATCH] D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete

Thu Jul 23 08:02:56 PDT 2020

ldionne added a comment.

In D75243#2169290 <https://reviews.llvm.org/D75243#2169290>, @froydnj wrote:

> The wider context is that we're building clang for use on our continuous integration infrastructure and for distribution to developers so that they can use the exact same version of clang that our infrastructure is using.  It is entirely possible that we should be building everything using different settings (or building a different set of things).
>
> I would expect the same sort of issues to come up when building the official releases (releases.llvm.org releases, that is, not Apple releases); are they built for the latest macOS release always, or do they take a different set of steps to ensure broad deployability?

Indeed, I would expect the same kind of issue too when building the LLVM releases. Actually, I've never understood why we included the runtimes in the LLVM releases (for macOS), because that seems contrary to the way we are handling runtimes in macOS, where they are part of the OS and not the toolchain.

While I said we were slightly more aggressive on requiring that the dylib is built for new OSes, we also try to accommodate to some extent, and in this case the failure you're encountering is not expected. The documentation says that we support building for macOS 10.12 and above. So I think the right fix is to add `-faligned-allocation` when building.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75243/new/

https://reviews.llvm.org/D75243