[libcxx-commits] [PATCH] D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete

Thu Jul 23 07:07:35 PDT 2020

froydnj added a comment.

In D75243#2169173 <https://reviews.llvm.org/D75243#2169173>, @ldionne wrote:

> In D75243#2168014 <https://reviews.llvm.org/D75243#2168014>, @dmajor wrote:
>
> > In our builds with the 10.12 SDK and MACOSX_DEPLOYMENT_TARGET of 10.11, this is producing
>
>
> Hmmm. There's a few interesting things here. First, I'd like to understand why you're building the dylib with a deployment target of 10.11 -- we usually make the assumption that people building libc++ are vendors, and we take for granted that they're building for new-ish platforms. For example, at Apple, we only build the dylib for the latest OS because that's what the dylib is going into, so using an older deployment target just doesn't make sense. If you have another use case, it might be useful to know about it for the future.

The wider context is that we're building clang for use on our continuous integration infrastructure and for distribution to developers so that they can use the exact same version of clang that our infrastructure is using.  It is entirely possible that we should be building everything using different settings (or building a different set of things).

I would expect the same sort of issues to come up when building the official releases (releases.llvm.org releases, that is, not Apple releases); are they built for the latest macOS release always, or do they take a different set of steps to ensure broad deployability?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75243/new/

https://reviews.llvm.org/D75243