[libcxx-commits] [PATCH] D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb added a comment.

In D83429#2142066 <https://reviews.llvm.org/D83429#2142066>, @ldionne wrote:

> Is it not possible to satisfy this convention in the compiler-rt tests?


That would require changing **a lot** of tests. I'm not sure the compiler-rt folks will approve this, given that the use case is quite narrow.

> I am uneasy to make this change because it's not tied to anything visible in libc++ or libc++abi. IOW, from my perspective it would be 100% valid to come back one year from now and clean up the "never used" `--test-executable` argument, only to see it fail somewhere in compiler-rt.

Can we remove the implicit inference and just pass this argument in libc++ tests? :)

> Is compiler-rt using the libc++ testing format? If not, I believe it should do so officially before we try to support it in these scripts.

It uses the `ShTest` format. I'm not trying to support the libc++ testing format in compiler-rt (although it would be great; the current configuration logic there is a total mess). Everything works today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83429/new/

https://reviews.llvm.org/D83429