[libcxx-commits] [PATCH] D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 9 09:59:35 PDT 2020


ldionne added a comment.

Is it not possible to satisfy this convention in the compiler-rt tests?

I am uneasy to make this change because it's not tied to anything visible in libc++ or libc++abi. IOW, from my perspective it would be 100% valid to come back one year from now and clean up the "never used" `--test-executable` argument, only to see it fail somewhere in compiler-rt.

Is compiler-rt using the libc++ testing format? If not, I believe it should do so officially before we try to support it in these scripts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83429/new/

https://reviews.llvm.org/D83429





More information about the libcxx-commits mailing list