[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

James Y Knight via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 6 13:12:31 PDT 2020


jyknight added a comment.

Of course, running into the problem also requires an asserts-enabled build of clang, because this change has triggered a Clang bug, which will need to be fixed before this can be recommitted.

All of the testing we did inside google previously for adding trivial_abi was all on a release build of clang, so we didn't trigger the assert there. :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490





More information about the libcxx-commits mailing list