[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jul 6 12:54:00 PDT 2020
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
I am suspecting the author did not run the tests with the unstable ABI enabled, which is to say the tests were never run. Otherwise a typo would not have gotten through. @oontvoo Please test this properly, update this patch with the fixed result that you'd like to commit. Then, I'll download the patch, run some basic tests on my side and commit it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82490/new/
https://reviews.llvm.org/D82490
More information about the libcxx-commits
mailing list