[libcxx-commits] [PATCH] D73743: Inline basic_string::erase for fastpath where __n == npos

Martijn Vels via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 19 14:55:36 PST 2020


mvels added a comment.

Is there a way I can easily tell phabricator that this is baselined against https://reviews.llvm.org/D74870 ?

I admit I don't understand phabricator well, or the mysterious ways it works.

On my local repo I rebased my branch, which works like a charm as that is ..... basic git.
Unfortunately arc diff then updates the wrong review, so I had to fix up both this one and D74870 <https://reviews.llvm.org/D74870>,

I also figured setting 'parent revision' would establish this (not so much).

Should I RTFM? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73743/new/

https://reviews.llvm.org/D73743





More information about the libcxx-commits mailing list