[libcxx-commits] [PATCH] D73743: Inline basic_string::erase for fastpath where __n == npos

[Martijn Vels via Phabricator via libcxx-commits]

mvels added inline comments.


================
Comment at: libcxx/include/string:3024
 
+// Inline-able portion of the erase() implementation (unstable)
+template <class _CharT, class _Traits, class _Allocator>
----------------
ldionne wrote:
> In what way is this unstable?
I agree this comment is confusing, as it details 'here is ABI detail' which we deliberately keep as a separate concern in __string.

So I removed the comment, if you have suggestions for a comment that may be helpful for a future reader or editor that may not be aware of this function potentially available for inlining under unstable, I welcome alternatives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73743/new/

https://reviews.llvm.org/D73743