[libcxx-commits] [PATCH] D67052: Add reference type transformation builtins

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added subscribers: cjdb, miscco.
miscco added a comment.

Some nits, looks great, especially for library concepts. Pinging @cjdb



================
Comment at: clang/lib/AST/TypePrinter.cpp:1020
 
   switch (T->getUTTKind()) {
     case UnaryTransformType::EnumUnderlyingType:
----------------
Couldn't we use `TextNodeDumper::VisitUnaryTransformType` to dump the string and then simplify it to a single case.

Given the possibility that maybe some day one might add the `add_foo` builtins


================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1110
+  if (T.expectAndConsume(diag::err_expected_lparen_after,
+                         "reference manipulation builtin",
+                         tok::r_paren)) return;
----------------
I dont think that this message is valid anymore now that you also remove qualifiers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67052/new/

https://reviews.llvm.org/D67052