[libcxx-commits] [libcxx] 592f354 - [libc++] Disable a filesystem test that uses debug mode with the macOS system libc++

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-02-11T14:57:14+01:00
New Revision: 592f35481aa5e43162f09edeaac9f27773991714

URL: https://github.com/llvm/llvm-project/commit/592f35481aa5e43162f09edeaac9f27773991714
DIFF: https://github.com/llvm/llvm-project/commit/592f35481aa5e43162f09edeaac9f27773991714.diff

LOG: [libc++] Disable a filesystem test that uses debug mode with the macOS system libc++

The system libc++.dylib doesn't support the debug mode, so this test
can't be supported. As a fly-by fix, we also specify more stringently
that only the macOS system library is unsupported in other tests using
the debug mode.

Added: 
    

Modified: 
    libcxx/test/libcxx/input.output/filesystems/class.path/path.itr/iterator_db.pass.cpp
    libcxx/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp
    libcxx/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/input.output/filesystems/class.path/path.itr/iterator_db.pass.cpp b/libcxx/test/libcxx/input.output/filesystems/class.path/path.itr/iterator_db.pass.cpp
index 2729e59029bc..d5df253603c1 100644
--- a/libcxx/test/libcxx/input.output/filesystems/class.path/path.itr/iterator_db.pass.cpp
+++ b/libcxx/test/libcxx/input.output/filesystems/class.path/path.itr/iterator_db.pass.cpp
@@ -11,6 +11,9 @@
 
 // MODULES_DEFINES: _LIBCPP_DEBUG=0
 
+// This test requires debug mode, which the library on macOS doesn't have.
+// UNSUPPORTED: with_system_cxx_lib=macosx
+
 // <filesystem>
 
 // class path

diff  --git a/libcxx/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp b/libcxx/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp
index b3621a4e697d..37ef0d1f04be 100644
--- a/libcxx/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp
+++ b/libcxx/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp
@@ -12,8 +12,8 @@
 
 // MODULES_DEFINES: _LIBCPP_DEBUG=0
 
-// Can't test the system lib because this test enables debug mode
-// UNSUPPORTED: with_system_cxx_lib
+// This test requires debug mode, which the library on macOS doesn't have.
+// UNSUPPORTED: with_system_cxx_lib=macosx
 
 // <future>
 

diff  --git a/libcxx/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp b/libcxx/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp
index 49a41362db9a..54778777056c 100644
--- a/libcxx/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp
+++ b/libcxx/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp
@@ -12,8 +12,8 @@
 
 // MODULES_DEFINES: _LIBCPP_DEBUG=0
 
-// Can't test the system lib because this test enables debug mode
-// UNSUPPORTED: with_system_cxx_lib
+// This test requires debug mode, which the library on macOS doesn't have.
+// UNSUPPORTED: with_system_cxx_lib=macosx
 
 // <future>