[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Wim Leflere via Phabricator via libcxx-commits]

WimLeflere updated this revision to Diff 314113.
WimLeflere added a comment.

Applied review comments

- replaced C++23 with C++2b and typedef with using
- added constexpr test function to re-use for runtime and compile time testing
- removed commented code and unnecessary constexpr_char_traits


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912

Files:
  libcxx/include/string
  libcxx/include/string_view
  libcxx/test/std/strings/basic.string/string.contains/contains.char.pass.cpp
  libcxx/test/std/strings/basic.string/string.contains/contains.ptr.pass.cpp
  libcxx/test/std/strings/basic.string/string.contains/contains.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/contains.char.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/contains.ptr.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/contains.string_view.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93912.314113.patch
Type: text/x-patch
Size: 14320 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201230/5f9dd0e0/attachment.bin>