[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Wim Leflere via Phabricator via libcxx-commits]

WimLeflere added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.ptr.pass.cpp:30
+//  S   s4  { s + 1, 4 };
+//  S   s5  { s,     5 };
+    S  sNot { "xyz", 3 };
----------------
Quuxplusone wrote:
> Why commented out?
The code is based on the `ends_with` test code, in which it's also commented out.
I'll remove it as it's not necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912