[libcxx-commits] [PATCH] D93383: [libc++] Use c++20 instead of c++2a consistently.

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 30 05:55:52 PST 2020

curdeius added inline comments.

Comment at: libcxx/include/__config:56
+#    define _LIBCPP_STD_VER 21  // current year, or date of c++2b ratification
 #  endif
 #endif  // _LIBCPP_STD_VER
Quuxplusone wrote:
> My understanding is that you're planning to make other changes in a separate PR to finish up adding a c++2b mode for real. And I like this patch and don't want to slow it down. But I echo what @miscco said: shouldn't you just go all the way to c++2b in //this// patch? Is there really a good reason to land this intermediate state rather than go all the way to c++2b in one hop?
The only reason I have is that this patch doesn't need a compiler with -std=c++2b support, whereas adding C++2b does need one.
I don't mind adding C++2b here, but I'll need to wait for D93520 to land first to do it.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list