[libcxx-commits] [PATCH] D93383: [libc++] Use c++20 instead of c++2a consistently.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__config:56
+#    define _LIBCPP_STD_VER 21  // current year, or date of c++2b ratification
 #  endif
 #endif  // _LIBCPP_STD_VER
----------------
My understanding is that you're planning to make other changes in a separate PR to finish up adding a c++2b mode for real. And I like this patch and don't want to slow it down. But I echo what @miscco said: shouldn't you just go all the way to c++2b in //this// patch? Is there really a good reason to land this intermediate state rather than go all the way to c++2b in one hop?


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:334
     "name": "__cpp_lib_char8_t",
-    "values": { "c++2a": int(201811) },
+    "values": { "c++20": int(201811) },
     "headers": ["atomic", "filesystem", "istream", "limits", "locale", "ostream",
----------------
(Naturally, this massively merge-conflicts with D93830, but I'm happy to deal with the conflict on D93830's side.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93383/new/

https://reviews.llvm.org/D93383