[libcxx-commits] [PATCH] D62641: Support arrays in make_shared and allocate_shared (P0674R1)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/include/memory:2714
+
+#if _LIBCPP_STD_VER > 17
+template<class _Tp, class = _EnableIf<!is_array_v<_Tp>>>
----------------
Review note: this is not an ABI break because prior to this patch, we didn't support array types in make_shared/allocate_shared. 


================
Comment at: libcxx/include/memory:2728
+{
+    [[no_unique_address]] _Alloc __alloc;
+    size_t __size;
----------------
I'm going to assume that by the time this lands, we only support compilers that support the `no_unique_address` feature (that is gcc or clang above v6).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62641/new/

https://reviews.llvm.org/D62641