[libcxx-commits] [PATCH] D93562: [libc++] Add a missing `<_Compare>` template argument.
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Dec 20 12:54:11 PST 2020
curdeius added a comment.
Excuse my ignorance, but could you please explain why letting `_Compare` get deduced is wrong/suboptimal?
IIUC the case you mention is when e.g. `__buffered_inplace_merge` has `_Compare` being some non-ref type `T`, so then calling `__half_inplace_merge` will deduce its `_Compare` to be an lvalue ref `T &`. So far so good. But why/when is it bad?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits