[libcxx-commits] [PATCH] D93414: [libc++] Adds a make_string test helper function.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 17 07:52:27 PST 2020


Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/support/test.support/make_string_header.pass.cpp:23
+      " !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMN"
+      "OPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~");
+
----------------
mclow.lists wrote:
> the indentation here makes it hard to see that the literals are supposed to be identical.
I'll have a look at manually formatting the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93414/new/

https://reviews.llvm.org/D93414



More information about the libcxx-commits mailing list