[libcxx-commits] [PATCH] D93414: [libc++] Adds a make_string test helper function.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

How about something more like:

  make_string<char>(
                    " !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMN"
                            "OPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~")
        ==          " !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMN"
                            "OPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~");

instead?



================
Comment at: libcxx/test/support/test.support/make_string_header.pass.cpp:23
+      " !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMN"
+      "OPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~");
+
----------------
the indentation here makes it hard to see that the literals are supposed to be identical.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93414/new/

https://reviews.llvm.org/D93414