[libcxx-commits] [PATCH] D93074: [libc++] Split allocator_traits and pointer_traits out of <memory>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I agree with your comments, however this is a split only, I'm keeping the code 100% the same to avoid mixing concerns. I actually do have a patch coming up that refactors `allocator_traits`, where I'll make sure to apply your comments.



================
Comment at: libcxx/include/__memory/allocator_traits.h:14
+#include <__config>
+#include <__memory/base.h>
+#include <__memory/pointer_traits.h>
----------------
miscco wrote:
> Should this also be __base.h to make clear that these are purely internal headers?
I've put the headers in a directory that had `__` in it to make it clear it was internal (and to avoid conflicting with user-provided directories as much as possible). I don't think it's necessary to have the file contain `__` too IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93074/new/

https://reviews.llvm.org/D93074