[libcxx-commits] [PATCH] D93074: [libc++] Split allocator_traits and pointer_traits out of <memory>

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added a comment.

I love hat you start breaking up the headers.



================
Comment at: libcxx/include/__memory/allocator_traits.h:14
+#include <__config>
+#include <__memory/base.h>
+#include <__memory/pointer_traits.h>
----------------
Should this also be __base.h to make clear that these are purely internal headers?


================
Comment at: libcxx/include/__memory/allocator_traits.h:34
+
+namespace __pointer_type_imp
+{
----------------
Maybe __pointer_type_impl ?

I have never seen imp as an abreviation. That said it is kind of fitting ;)


================
Comment at: libcxx/include/__memory/allocator_traits.h:37
+
+template <class _Tp, class _Dp, bool = __has_pointer_type<_Dp>::value>
+struct __pointer_type
----------------
I _guess_ `Dp` stands for decayed type but I am not even sure

Could we give it a better name so that it is more obvious for new readers what it is?


================
Comment at: libcxx/include/__memory/base.h:72
+}
+#endif
+
----------------
Missing comment here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93074/new/

https://reviews.llvm.org/D93074