[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Looks okay except for the synopsis nitpick, however as you say the Apple ABI list needs to be updated. If you rebase on top of `master` and re-submit, the failing jobs should tell you what symbols you're missing (in the logs). You could add them to the Apple ABI lists (please make sure to sort :-), and the CI should pass.



================
Comment at: libcxx/include/format:16
+namespace std {
+  // [format.context], class template basic_format_context
+  template<class Out, class charT> class basic_format_context;
----------------
The synopsis should only contain the parts that we implement. Or at least it's always been my impression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214