[libcxx-commits] [PATCH] D91154: [libc++] Guard __cpp_lib_constexpr_dynamic_alloc with compiler support

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/construct.pass.cpp:175
 
-#if TEST_STD_VER > 17
     static_assert(test());
----------------
Same as below.


================
Comment at: libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/destroy.pass.cpp:134
     test();
-#if TEST_STD_VER > 17
     static_assert(test());
----------------
I'd much rather keep this conditioned on `TEST_STD_VER`. Otherwise, we're assuming that `__cpp_constexpr_dynamic_alloc` is defined properly, else this will never get tested.

This shouldn't be an issue since the test is disabled with older Clangs anyway.


================
Comment at: libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.pass.cpp:83
 
-#if TEST_STD_VER > 17
 template <size_t Align>
----------------
Same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91154/new/

https://reviews.llvm.org/D91154