[libcxx-commits] [PATCH] D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 1 14:04:39 PST 2020

mstorsjo added inline comments.

Comment at: libcxx/src/filesystem/operations.cpp:176
     case PS_InRootDir:
-      return "/";
+      return PS("/");
     case PS_InTrailingSep:
mstorsjo wrote:
> amccarth wrote:
> > Is "/" the preferred representation of the root directory even on Windows?
> No; this patch just handles the char->wchar transition. This particular case is changed to return backslashes in D91176 as part of making the path parser handle windows specific concepts as "root name".
Ok, I see that I generally change the preferred separator to backslashes here, so I guess I could move that bit from that other patch into this one as well if you want it strictly that way - it originated in that patch as it came from trying to make the path parser/iterator return the right things.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list