[libcxx-commits] [PATCH] D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 1 14:01:12 PST 2020
mstorsjo added inline comments.
================
Comment at: libcxx/src/filesystem/operations.cpp:176
case PS_InRootDir:
- return "/";
+ return PS("/");
case PS_InTrailingSep:
----------------
amccarth wrote:
> Is "/" the preferred representation of the root directory even on Windows?
No; this patch just handles the char->wchar transition. This particular case is changed to return backslashes in D91176 as part of making the path parser handle windows specific concepts as "root name".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91135/new/
https://reviews.llvm.org/D91135
More information about the libcxx-commits
mailing list