[libcxx-commits] [PATCH] D66970: [libc++] Explicitly provide a list of exported symbols for libc++

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd added a comment.

I think that controlling via annotations is actually very useful.  It will actually still be needed to ensure that libc++ continues to build on Windows properly (which really does want the annotations).  The annotations being applied there makes it easy to then handle properly on the other platforms as well.  Additionally, diffs explicitly call out the interface in the change, which again helps review the changes.  Finally, there are some symbols which are synthesized by the compiler and the visibility for those are controlled by means of the annotation on the associated class.  This again is far easier to manage with the explicit annotation rather than the explicit export list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66970/new/

https://reviews.llvm.org/D66970