[libcxx-commits] [PATCH] D66970: [libc++] Explicitly provide a list of exported symbols for libc++

Wed Sep 4 09:44:56 PDT 2019

ldionne added a comment.

In D66970#1657905 <https://reviews.llvm.org/D66970#1657905>, @zoecarver wrote:

> In D66970#1657660 <https://reviews.llvm.org/D66970#1657660>, @mclow.lists wrote:
>
> > I see maintaining an explicit list of exports as an ongoing time sink - are you sure this is the the direction that we want to take?
>
>
> We can probably automate the creation of this list. Maybe we could add it to CI?

I don't think we want to automate it. The very purpose is to have _explicit_ control over symbols that we export. That way, we do not end up exporting symbols that we wish we did not export.

When a vendor exports a symbols from the dylib, it needs to export it for ever.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66970/new/

https://reviews.llvm.org/D66970