[libcxx-commits] [PATCH] D68952: Guard against possible overflow in span.subpan

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

In D68952#1716195 <https://reviews.llvm.org/D68952#1716195>, @miscco wrote:

> When implementing `span` for MS STL I locally used the libcx tests against my implementation, i found that there are some instances where libcxx is not fully conforming (due to rapidly shifting span specification). Should I prepare one big patch or go on incrementally.


How many cases are we talking about?
In general, I would say incrementally.
Smaller patches are easier to review.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68952/new/

https://reviews.llvm.org/D68952