[libcxx-commits] [PATCH] D68952: Guard against possible overflow in span.subpan

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added a comment.

When implementing `span` for MS STL I locally used the libcx tests against my implementation, i found that there are some instances where libcxx is not fully conforming (due to rapidly shifting span specification). Should I prepare one big patch or go on incrementally.

> [snip]
> 
> I don't find that code to be simpler.
>  It's shorter, but harder to understand.

What I find better about that code is that it is equivalent to the other `subspan` methods. I will definitely add a test against the error cases


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68952/new/

https://reviews.llvm.org/D68952