[libcxx-commits] [PATCH] D68805: [libcxx] Remove shared_ptr::make_shared

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

@ldionne, yes. I suspect this is the patch that will cause a SEGFAULT. It could also be a similar part of the patch where I remove `std::shared_ptr::allocate_shared`, though. If it does cause a SEGFAULT we will know exactly where the issue is and it will be easier to debug.

We could mangle the function. But, part of the reason for this change is removing as much code from `make_shared` as possible so, later, when I add more overloads, there will be less duplication. Additionally, I don't think it makes sense to add an extra layer of abstraction when it gives us no benefit. If we don't want `__create_with_cntrl_block` I would still like to remove `std::shared_ptr::make_shared` (and `std::shared_ptr::__make_shared`).

D62641 <https://reviews.llvm.org/D62641> depends on this functionality but, it shouldn't be too hard to update that patch (and I wouldn't mind doing it if you want me to remove `__create_with_cntrl_block`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68805/new/

https://reviews.llvm.org/D68805