[libcxx-commits] [PATCH] D68805: [libcxx] Remove shared_ptr::make_shared

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a subscriber: phosek.
ldionne added a comment.
This revision now requires changes to proceed.

Can you confirm this is the bit of the patch that we suspect had caused a SEGFAULT for @phosek?

Also, is there a reason why we can't just rename `shared_ptr<_Tp>::make_shared` to `shared_ptr<_Tp>::__make_shared`, without changing the logic and the signature? Do you have other changes pending that depend on that?

Note: Requesting changes so it shows up properly in my review queue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68805/new/

https://reviews.llvm.org/D68805