[libcxx-commits] [PATCH] D68971: [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug

Saleem Abdulrasool via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 15 10:20:26 PDT 2019


compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Thanks, this should be more robust.  Nice catch with the image base being explicitly set and using `p_vaddr` rather than `p_offset`, that was something that I failed to account for.  I really wish that we had a more complete test suite, but that is *way* beyond this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68971/new/

https://reviews.llvm.org/D68971





More information about the libcxx-commits mailing list