[libcxx-commits] [PATCH] D68971: [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added reviewers: srhines, danalbert, compnerd.
rprichard added a comment.

FWIW, Android's official toolchain currently only uses LLVM's libunwind for arm32, so this patch doesn't affect anything yet in the Android platform or NDK. I tested it with NDK r20 by:

- building libunwind.a with -DLIBUNWIND_TARGET_TRIPLE=i686-linux-android16, then
- building a PIE executable, linking libunwind.a in front of the libgcc.a unwinder that NDK r20 normally uses.

I verified that libunwind.a was broken on an API16 x86-32 emulator when I used a non-zero -Wl,--image-base=nnnn setting, but this patch fixes it.

(I also tried running the libunwind tests but didn't get them to run.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68971/new/

https://reviews.llvm.org/D68971