[libcxx-commits] [PATCH] D68269: [libc++abi] Do not define new/delete by default

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/libcxx/test/config.py:765
+            # With GCC's linker, re-linking libc++ after libc++abi is necessary
+            # since libc++abi depends on new/delete, which is provided in libc++.
+            # With other linkers, this is redundant but harmless.
----------------
We want the link line we generate to match exactly what Clang spits out. Otherwise we're potentially hiding bugs.

In this case, Clang will fail to link programs with the installed version of libc++.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68269/new/

https://reviews.llvm.org/D68269