[libcxx-commits] [PATCH] D68269: [libc++abi] Do not define new/delete by default

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D68269#1692076 <https://reviews.llvm.org/D68269#1692076>, @dim wrote:

> Hm, we don't use libc++abi in FreeBSD (at least not by default), but libcxxrt, which has its own new/delete definitions.  I never noticed a conflict with libc++ though, since when is it providing new/delete by itself?


libc++ always provides new/delete unless you provide `-DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=OFF` at CMake configuration time. Those definitions might be weak, though, and that could be why the ones from libcxxrt are used instead? It would be worth double-checking. At the very least, I can say that the definitions of `new`/`delete` are weak in both libc++ and libc++abi, on Ubuntu (tested on a Docker container).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68269/new/

https://reviews.llvm.org/D68269