[libcxx-commits] [PATCH] D68343: [libc++] Move the linker script generation step to CMake

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added a comment.

@phosek @thakis I do have one question. Is there a reason why we want the linker script to look like

  TODO: linker script

instead of

  



================
Comment at: libcxx/cmake/Modules/DefineLinkerScript.cmake:47
+    COMMAND "${CMAKE_COMMAND}" -E echo "${linker_script}" > "${symlink}"
+    COMMENT "Generating linker script: '${linker_script}' as file ${symlink}"
+    VERBATIM
----------------
thakis wrote:
> We recently made it so that the script is silent during normal operation. It looks like this adds the build output back. Could you omit this please? Successful build steps should be silent.
This build output is only included if the verbose mode of the CMake generator is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68343/new/

https://reviews.llvm.org/D68343