[libcxx-commits] [PATCH] D68343: [libc++] Move the linker script generation step to CMake

[Nico Weber via Phabricator via libcxx-commits]

thakis added inline comments.


================
Comment at: libcxx/cmake/Modules/DefineLinkerScript.cmake:47
+    COMMAND "${CMAKE_COMMAND}" -E echo "${linker_script}" > "${symlink}"
+    COMMENT "Generating linker script: '${linker_script}' as file ${symlink}"
+    VERBATIM
----------------
We recently made it so that the script is silent during normal operation. It looks like this adds the build output back. Could you omit this please? Successful build steps should be silent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68343/new/

https://reviews.llvm.org/D68343