[libcxx-commits] [PATCH] D70282: [libc++] [chrono] Fix year_month_weekday::ok() implementation.

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 15 01:06:09 PST 2019


mclow.lists added inline comments.


================
Comment at: libcxx/test/std/utilities/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/ok.pass.cpp:54
 
     static_assert( year_month_weekday{year{2019},   January, weekday_indexed{Tuesday, 1}}.ok(), ""); // All OK
+    static_assert( year_month_weekday{year{2019},   January, weekday_indexed{Tuesday, 4}}.ok(), ""); // All OK
----------------
How about a test for the 0th Wednesday, and the -1st Tuesday?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70282/new/

https://reviews.llvm.org/D70282





More information about the libcxx-commits mailing list