[libcxx-commits] [PATCH] D70282: [libc++] [chrono] Fix year_month_weekday::ok() implementation.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

The code here looks fine to me, but I want to think about the tests for a bit.
Thanks for the patch.



================
Comment at: libcxx/include/chrono:1861
 
+  // TODO: Make private?
   static constexpr unsigned char __weekday_from_days(int __days) noexcept;
----------------
There's no need to remove this at this time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70282/new/

https://reviews.llvm.org/D70282