[libcxx-commits] [PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

[Arthur O'Dwyer via libcxx-commits]

FWIW, I think it's a lot harder to make this kind of typo-bug if you always
(always!) keep all your numbers in number-line order, with all the
alligators' mouths opening to the right:

    return CT_Vector *<*= CT && CT *<*= CT_ForwardList;

Some programming languages (not C++) even let you omit the intermediate "&&
CT", to make the math even clearer.

(The committed fix did not adopt this style, but I think it should have.)

my $.02,
–Arthur


On Wed, Nov 13, 2019 at 1:00 AM David Zarzycki via Phabricator via
cfe-commits <cfe-commits at lists.llvm.org> wrote:

> davezarzycki added a comment.
>
> Let's just fix the bug: 1d55c9e59ebf3f3ff572d42da433b2f72f1ce900 <
> https://reviews.llvm.org/rG1d55c9e59ebf3f3ff572d42da433b2f72f1ce900>
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D69292/new/
>
> https://reviews.llvm.org/D69292
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191113/0499a953/attachment.html>