[libcxx-commits] [PATCH] D62618: [libcxx] Make std::tuple<> trivially constructible

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: libcxx/include/tuple:910
     _LIBCPP_INLINE_VISIBILITY
-    _LIBCPP_CONSTEXPR tuple() _NOEXCEPT {}
+    _LIBCPP_CONSTEXPR tuple() _NOEXCEPT _LIBCPP_DEFAULT
     template <class _Alloc>
----------------
EricWF wrote:
> ldionne wrote:
> > EricWF wrote:
> > > This is C++11 and up so you can just write `= default`.
> > I thought this was trying to work in C++03 -- isn't that why we're using `_NOEXCEPT` and `_LIBCPP_CONSTEXPR`??
> Not really. And even then I believe Clang accepts `= default`  as an extension in C++03. 
Yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62618/new/

https://reviews.llvm.org/D62618