[libcxx-commits] [PATCH] D62618: [libcxx] Make std::tuple<> trivially constructible

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 29 13:51:17 PDT 2019


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Thanks for the link Louis. This should be safe then. .



================
Comment at: libcxx/include/tuple:910
     _LIBCPP_INLINE_VISIBILITY
-    _LIBCPP_CONSTEXPR tuple() _NOEXCEPT {}
+    _LIBCPP_CONSTEXPR tuple() _NOEXCEPT _LIBCPP_DEFAULT
     template <class _Alloc>
----------------
ldionne wrote:
> EricWF wrote:
> > This is C++11 and up so you can just write `= default`.
> I thought this was trying to work in C++03 -- isn't that why we're using `_NOEXCEPT` and `_LIBCPP_CONSTEXPR`??
Not really. And even then I believe Clang accepts `= default`  as an extension in C++03. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62618/new/

https://reviews.llvm.org/D62618





More information about the libcxx-commits mailing list