[libcxx-commits] [PATCH] D62428: [libcxx] Slightly improved policy for handling experimental features

[JF Bastien via Phabricator via libcxx-commits]

jfb added inline comments.


================
Comment at: libcxx/docs/DesignDocs/ExperimentalFeatures.rst:25
+The "end game" of a Technical Specification (TS) is to have the features in
+there added to a future version of the C++ standard. When this happens, the TS
+can be retired. Sometimes, only part of at TS is added to the standard, and
----------------
I generally capitalize "Standard".


================
Comment at: libcxx/docs/DesignDocs/ExperimentalFeatures.rst:39
+When a feature is adopted into the main standard, we implement it in namespace
+``std``. We then create a deprecation warning for the corresponding experimental
+feature warning users to move off of it and to the now-standardized feature.
----------------
I think you want to specify: when implemented fully. Sometimes we can ship something that's not complete yet, and we can't start the deprecation clock until the implementation is complete.


================
Comment at: libcxx/docs/DesignDocs/ExperimentalFeatures.rst:46
+
+After **2 releases**, the experimental feature is removed completely (and the
+deprecation notice too). Using the experimental feature simply becomes an
----------------
2 releases of LLVM? What do we call "open source public Official LLVM"?


================
Comment at: libcxx/docs/DesignDocs/ExperimentalFeatures.rst:139
+-------------------------------------------
+The FileSystem TS was accepted (in toto) for C++17.
+The FileSystem TS implementation was shipped in namespace ``std`` in LLVM 7.0, and will be removed in LLVM 11.0 (due to the lack of deprecation warnings before LLVM 9.0).
----------------
toto africa?


================
Comment at: libcxx/docs/UsingLibcxx.rst:89
+      the experimental feature is removed two releases after the non-experimental
+      version has shipped.
 
----------------
Link to the policy from here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62428/new/

https://reviews.llvm.org/D62428