[libcxx-commits] [PATCH] D59607: libc++/win: Make once_flag have the same size as a pointer
Nico Weber via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 22 06:33:22 PDT 2019
thakis marked an inline comment as done.
thakis added a comment.
In D59607#1438932 <https://reviews.llvm.org/D59607#1438932>, @BillyONeal wrote:
> We (MSVC++) could just fix pplwin.h to not have this assumption, since clang doesn't need the workaround that forces us to reinterperet_cast void*, but that fix probably wouldn't make it shipped until VS 2019 Update 1 at the earliest (I'd have to go through ship room) and Update 2 more likely.
> Comments in the other reivew about "it's odd that you're trying to use libc++ but linking with msvc++'s STL DLL, msvcp140.dll", still apply here :)
I think this is a good change regardless: it didn't look intentional that `once_flag::__state_` was 64-bit on 64-bit systems everywhere except on Windows. It seems someone just wasn't thinking of LLP64 / LP64.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits