[libcxx-commits] [PATCH] D59607: libc++/win: Make once_flag have the same size as a pointer

Billy Robert O'Neal III via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 21 19:15:31 PDT 2019


BillyONeal added a comment.

We (MSVC++) could just fix pplwin.h to not have this assumption, since clang doesn't need the workaround that forces us to reinterperet_cast void*, but that fix probably wouldn't make it shipped until VS 2019 Update 1 at the earliest (I'd have to go through ship room) and Update 2 more likely.

Comments in the other reivew about "it's odd that you're trying to use libc++ but linking with msvc++'s STL DLL, msvcp140.dll", still apply here :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59607/new/

https://reviews.llvm.org/D59607





More information about the libcxx-commits mailing list