[libcxx-commits] [PATCH] D63230: Add observer_ptr

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 7 inline comments as done.
zoecarver added inline comments.


================
Comment at: include/experimental/memory:81
+    template<class _W2,
+             class = enable_if_t<is_convertible<_W2*, _Wp*>::value>>
+    constexpr observer_ptr(observer_ptr<_W2> __other) noexcept
----------------
EricWF wrote:
> Use the new `_EnableIf` trait instead of `enable_if_t`.
Will do, but any specific reason for this?


================
Comment at: include/experimental/memory:95
+    // conversions
+    constexpr /*explicit*/ operator pointer() const noexcept { return __ptr; }
+
----------------
EricWF wrote:
> Why is `explicit` commented out`?
> 
> 
I would expect `is_convertible< observer_ptr<T>, T*>` to be true, but when this is explicit that statement is not true. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63230/new/

https://reviews.llvm.org/D63230