[libcxx-commits] [PATCH] D63230: Add observer_ptr

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added a comment.

I am so glad you like it :) thanks for the review @EricWF! I will add constexpr tests and fix the comments.



================
Comment at: include/experimental/memory:168
+    return __a < __b; // TODO: is this really correct?
+}
+
----------------
xbolva00 wrote:
> Standard says "Returns: p2 < p1.".
> 
> So in your case, "__b < __a" ?
How did I miss this... I read over it so many times. Anyway, thank you @xbolva00.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63230/new/

https://reviews.llvm.org/D63230