[libcxx-commits] [PATCH] D63230: Add observer_ptr

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver updated this revision to Diff 204709.
zoecarver added a comment.
Herald added subscribers: christof, mgorny.

- new header things

>> Questions:
>> 
>> Is it okay to use constexpr and noexcept or should I use the macros?
> 
> Yes. For entirely new features, all of C++11 and C++14 are on the table now.
>  But for additions or changes to existing components, use the same style as the existing code.

Good to know. Thanks.

>> I think there is something else I need to do when adding a header.
> 
> There's a set up steps here:
>  https://github.com/llvm-mirror/libcxx/blob/master/NOTES.TXT#L19
> 
> But generally it looked good.

Done.

>> The greater than operator seemed wrong.
> 
> Say more?

The standard says that the greater than and less than operators should have the same functionality. This seems wrong to me, but I might be missing something.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63230/new/

https://reviews.llvm.org/D63230

Files:
  include/CMakeLists.txt
  include/experimental/memory
  include/module.modulemap
  test/libcxx/double_include.sh.cpp
  test/libcxx/experimental/memory/memory.observer.ptr/version.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/conv.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/ctor.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/hash.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/mod/release.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/mod/reset.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/mod/swap.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/obs.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/spec.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63230.204709.patch
Type: text/x-patch
Size: 22311 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190614/657c7376/attachment-0001.bin>