[libcxx-commits] [PATCH] D63230: Add observer_ptr

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

> Questions:
> 
> Is it okay to use constexpr and noexcept or should I use the macros?

Yes. For entirely new features, all of C++11 and C++14 are on the table now.
But for additions or changes to existing components, use the same style as the existing code.

> Should this use the experimental namespace? The paper made it seem like std was sufficient.

We implement a C++ standard, what namespace does it say?

> I think there is something else I need to do when adding a header.

There's a set up steps here:
https://github.com/llvm-mirror/libcxx/blob/master/NOTES.TXT#L19

But generally it looked good.

> The greater than operator seemed wrong.

Say more?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63230/new/

https://reviews.llvm.org/D63230